Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(cron): Log excess memory usage at debug and info levels #45843

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 12, 2024

Backport of #45530

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@joshtrichards
Copy link
Member

/update-3rdparty

@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2024
@blizzz blizzz mentioned this pull request Jun 17, 2024
8 tasks
@joshtrichards joshtrichards force-pushed the backport/45530/stable29 branch from 6390e78 to 4190d6a Compare June 17, 2024 20:21
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyXheli

This comment has been minimized.

@nickvergessen
Copy link
Member

nickvergessen commented Jun 19, 2024

The log you posted will not happen in the future anymore, because && $memoryPeakBefore <= 300_000_000 is not true as the before: 554.9 MB is not smaller than 300 MB

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards force-pushed the backport/45530/stable29 branch from fccd54b to 92fce66 Compare June 27, 2024 21:08
@nickvergessen nickvergessen merged commit 8abf72b into stable29 Jun 28, 2024
168 checks passed
@nickvergessen nickvergessen deleted the backport/45530/stable29 branch June 28, 2024 06:45
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
@AndyXheli
Copy link

Hi still seeing this on NC 29.0.4

{"reqId":"kImcJ5WNoR8EST80crIE","level":2,"time":"2024-07-28T21:17:03-05:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"Cron job used more than 300 MB of ram after executing job OCA\\Recognize\\BackgroundJobs\\ClusterFacesJob (id: 226426, arguments: {\"userId\":\"admin\"}): 652.1 MB (before: 99.5 MB)","userAgent":"--","version":"29.0.4.1","data":{"app":"cron"},"id":"66a7bdec119fb"}

{"reqId":"IXdi9NgDcaj3o5rTidfQ","level":2,"time":"2024-07-28T21:01:47-05:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"Cron job used more than 300 MB of ram after executing job OCA\\Recognize\\BackgroundJobs\\ClusterFacesJob (id: 226389, arguments: {\"userId\":\"admin\"}): 625.5 MB (before: 10.6 MB)","userAgent":"--","version":"29.0.4.1","data":{"app":"cron"},"id":"66a7bdec11a7f"}

@joshtrichards
Copy link
Member

Yes, the logging is legitimate. It's to catch large memory consumers. Report it to the recognize repo please, since that's the job that is using the memory in your case.

@nickvergessen
Copy link
Member

In your sample the memory usage increased by 615MB and 550MB. Exactly the cases we want to log. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: logging feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants