Avoid duplicate files in google with the same name #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it renames the temporary file, it tests if the file is already present. If so, it moves to trash the previous version to avoid duplicate files with the same name (message log: "Ignoring duplicate file name: ... on Google Drive for Google user: ..."). It doesn't handle duplicate files in Google Drive, it tries to avoid them. You'll watch #4279 issue.
Signed-off-by: gvmura <gvmura@uniss.it>
…ura/server into avoid-duplicate-files-google
Codecov Report
@@ Coverage Diff @@
## master #4416 +/- ##
============================================
- Coverage 54.18% 54.17% -0.01%
- Complexity 21635 21638 +3
============================================
Files 1327 1327
Lines 82778 82786 +8
Branches 1312 1312
============================================
- Hits 44853 44852 -1
- Misses 37925 37934 +9
|
|
I don't have much experience with Git. You can use my codes from yourself. |
icewind1991
approved these changes
Apr 24, 2017
rullzer
approved these changes
Apr 24, 2017
|
@MorrisJobke |
|
cc @icewind1991 what do you think? Is this okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it renames the temporary file, it tests if the file is already present. If so, it moves to trash the previous version to avoid duplicate files with the same name (message log: "Ignoring duplicate file name: ... on Google Drive for Google user: ...").
It doesn't handle duplicate files in Google Drive, it tries to avoid them.
You'll watch #4279 issue.
Logs file and images:
logs-images.zip
I tested owncloud 9.1.5 yesterday and I saw that when it uploads the file for the second time, it handles Google's versions. No "temporary" file is created in Google. So my fix isn't necessary in it.