Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide app-updated notifications for users #43967

Merged
merged 8 commits into from
Mar 7, 2024
Merged

feat: Provide app-updated notifications for users #43967

merged 8 commits into from
Mar 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2024 •
edited
Loading

Summary

This provides information on what changed on an app update for users:
If notifications are enabled users will receive a notification for an app update if that app is enabled for that user.
The update notification is only provided if a changelog exists, to allow technical changelog and user changelogs following logic is applied:
As per appstore documentation CHANGELOG.md is used for technical changelogs (e.g. developers or administrators).
For users the CHANGELOG.{code}.md file is used ({code} is the language code), and it falls back to CHANGELOG.en.md if the requested language is missing.

Meaning: For user changelog CHANGELOG.{lang}.md with fallback CHANGELOG.en.md is used, for admins or developers use CHANGELOG.md.

Screen cast

vokoscreenNG-2024-03-03_18-34-33.mp4

TODO

  • Add app config options to admin docs
  • Would be nice to have unit tests.

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 3, 2024
@susnux susnux mentioned this pull request Mar 3, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 3, 2024
View reviewed changes
apps/updatenotification/lib/Controller/APIController.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Controller/APIController.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Controller/APIController.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Controller/APIController.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Fixed Show fixed Hide fixed
@susnux susnux force-pushed the feat/app-updated-notification branch from 0cce43a to 8433293 Compare March 3, 2024 21:47
nickvergessen
nickvergessen requested changes Mar 4, 2024
View reviewed changes
apps/updatenotification/appinfo/routes.php Outdated Show resolved Hide resolved
apps/updatenotification/lib/BackgroundJob/AppUpdatedNotifications.php Outdated Show resolved Hide resolved
apps/updatenotification/lib/Controller/APIController.php Show resolved Hide resolved
apps/updatenotification/lib/BackgroundJob/ResetToken.php Show resolved Hide resolved
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Outdated Show resolved Hide resolved
lib/public/RichObjectStrings/Definitions.php Outdated Show resolved Hide resolved
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Outdated Show resolved Hide resolved
apps/updatenotification/lib/Notification/AppUpdateNotifier.php Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/app-updated-notification branch 3 times, most recently from faccee1 to 2dd3d58 Compare March 4, 2024 17:04
@susnux susnux force-pushed the feat/app-updated-notification branch 2 times, most recently from c1bd12b to f9b9ff5 Compare March 4, 2024 23:04
@susnux susnux force-pushed the feat/app-updated-notification branch from f9b9ff5 to 5f9c835 Compare March 4, 2024 23:51
@susnux susnux force-pushed the feat/app-updated-notification branch from 5f9c835 to f36c45d Compare March 5, 2024 10:58
@susnux susnux marked this pull request as ready for review March 5, 2024 11:05
@susnux susnux requested review from come-nc and emoral435 March 5, 2024 11:05
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 5, 2024
@susnux susnux requested review from artonge and sorbaugh March 5, 2024 11:07
@susnux
Copy link
Contributor Author

susnux commented Mar 5, 2024 •
edited
Loading

How to test?
Install and enable the "QA testing" app, then add a CHANGELOG.en.md to the testing app folder, increase the version number in appinfo and run the update in nextcloud -> see changes notification.

@susnux susnux requested a review from provokateurin as a code owner March 7, 2024 09:56
@susnux susnux force-pushed the feat/app-updated-notification branch from c258ab3 to c6196d0 Compare March 7, 2024 10:39
@susnux susnux force-pushed the feat/app-updated-notification branch from c6196d0 to 8e8a04f Compare March 7, 2024 11:00
@susnux susnux force-pushed the feat/app-updated-notification branch 4 times, most recently from c1e8013 to fc55c75 Compare March 7, 2024 18:28
susnux added 8 commits March 7, 2024 22:40
@susnux @skjnldsv
fix(updatenotification): Replace deprecated code and move background …
d9d3448 
…jobs into `BackgroundJobs` subfolder

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
feat(updatenotification): Add notification for users when apps are up…
fa14daf 
…dated

* Open app changelog dialog when available (webui)
* Fallback to open changelog page for mobile clients

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
fix(updatenotification): Update tests to match with changed constructors
9c1a87a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
fix(updatenotification): Resolve static code analysis errors
31d24a5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
fix(updatenotification): Add migration step to replace and remove ren…
40ae129 
…amed background jobs

This can be dropped with Nextcloud 30.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
feat(updatenotification): Allow to disable the app updated notificati…
2672884 
…ons and allow to en/disable guest users notification

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
feat(AppManager): Provide getAppIcon function
876e2d6 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
chore: Compile assets
b969eab 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv force-pushed the feat/app-updated-notification branch from fc55c75 to b969eab Compare March 7, 2024 21:44
@skjnldsv skjnldsv merged commit cf888e9 into master Mar 7, 2024
35 of 37 checks passed
@skjnldsv skjnldsv deleted the feat/app-updated-notification branch March 7, 2024 21:44
This was referenced Mar 7, 2024
Merged
Merged
Merged
@ArtificialOwl ArtificialOwl mentioned this pull request Mar 12, 2024
Merged
@susnux susnux mentioned this pull request May 6, 2024
Closed
5 tasks
This was referenced Dec 1, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@come-nc come-nc come-nc approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter JuliaKirschenheuter is a code owner

@emoral435 emoral435 Awaiting requested review from emoral435

@artonge artonge Awaiting requested review from artonge

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: activity and notification feature: install and update pending documentation This pull request needs an associated documentation update 🍀 2024-Spring
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
7 participants
@susnux @come-nc @nickvergessen @AndyScherzinger @sorbaugh @joshtrichards @skjnldsv