Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename renderHTML to renderHtml #4384

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Rename renderHTML to renderHtml #4384

merged 1 commit into from
Apr 19, 2017

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 18, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Apr 18, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @schiessle and @rullzer to be potential reviewers.

@MorrisJobke MorrisJobke mentioned this pull request Apr 18, 2017
Closed
@georgehrke
Copy link
Member

We are touching a public API here. Can we have a deprecated renderHTML that just calls renderHtml?

@rullzer
Copy link
Member

rullzer commented Apr 19, 2017

@georgehrke it is only public API once 12 is released.

@georgehrke
Copy link
Member

Ok, never mind then :)

@rullzer
Copy link
Member

rullzer commented Apr 19, 2017

@MorrisJobke conflicts!

@schiessle schiessle mentioned this pull request Apr 19, 2017
Merged
@MorrisJobke
Rename renderHTML to renderHtml
16c4755 
* fixes #4383
* improves consistency

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov
Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #4384 into master will decrease coverage by 0.1%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #4384      +/-   ##
============================================
- Coverage      54.2%   54.09%   -0.11%     
+ Complexity    21597    21591       -6     
============================================
  Files          1327     1327              
  Lines         82538    82294     -244     
  Branches       1305     1305              
============================================
- Hits          44739    44517     -222     
+ Misses        37799    37777      -22
Impacted Files Coverage Δ Complexity Δ
settings/Hooks.php 0% <0%> (ø) 12 <0> (ø) ⬇️
apps/sharebymail/lib/ShareByMailProvider.php 62.46% <0%> (-6.29%) 64 <0> (-1)
lib/private/Mail/EMailTemplate.php 70.32% <100%> (ø) 32 <3> (ø) ⬇️
core/Controller/LostController.php 83.07% <100%> (-0.51%) 26 <0> (ø)
settings/Mailer/NewUserMailHelper.php 76.11% <100%> (ø) 8 <0> (ø) ⬇️
lib/private/User/Manager.php 80.7% <0%> (-3.12%) 66% <0%> (-2%)
core/Controller/OCSController.php 77.35% <0%> (-1.08%) 9% <0%> (ø)
...s/files_sharing/lib/Controller/ShareController.php 46.35% <0%> (-0.39%) 59% <0%> (ø)
... and 7 more

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2017
@MorrisJobke MorrisJobke merged commit 0556104 into master Apr 19, 2017
@MorrisJobke MorrisJobke deleted the renderHtml-fix branch April 19, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.

Inconsistency in casing
4 participants
@MorrisJobke @mention-bot @georgehrke @rullzer