Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] chore: Update @nextcloud/router to 2.2.1 #43092

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 24, 2024

Summary

davRemotePath from @nextcloud/files is initialized before OC.webroot is, due to OC/util.js is loaded (which uses @nextcloud/files) before OC/webroot.js.

Now @nextcloud/files call @nextcloud/router which required OC.webroot set. To fix this the 2.2.1 release of @nextcloud/router provides the webroot logic by itself.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Jan 24, 2024
@susnux susnux added this to the Nextcloud 27.1.7 milestone Jan 24, 2024
@susnux susnux changed the title chore: Update @nextcloud/router to 2.2.1 [stable27] chore: Update @nextcloud/router to 2.2.1 Jan 24, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Jan 25, 2024

drone samba unrelated

@susnux susnux merged commit 075847d into stable27 Jan 25, 2024
37 of 38 checks passed
@susnux susnux deleted the fix/27-router branch January 25, 2024 18:12
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants