Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that #41636

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 21, 2023

In the office integration we don't want to show the sidebar after opening a file through a direct link as it takes away too much space. We just call a sidebar close within richdocuments but the deferred call to show the details view on the scrollTo action will trigger later. In this case we can actually avoid trigger the details view that way as it is already called when the file action is triggered a few lines below

OCA.Files.Sidebar.open(fileInfo.path);

This fix is targeting 27 only as master might have changed behaviour due to the files2vue migration (needs #41467 to be re-evaluated)

Summary

TODO

  • ...

Checklist

@juliusknorr juliusknorr changed the title fix: Avoid triggering a defered sidebar open if openFile is already handling that [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that Nov 21, 2023
@juliusknorr juliusknorr requested review from a team, Pytal, szaimen and emoral435 and removed request for a team November 21, 2023 11:49
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Nov 21, 2023
@solracsf solracsf added this to the Nextcloud 27.1.5 milestone Nov 21, 2023
@Darshan-upadhyay1110
Copy link

Tested https://github.com/nextcloud/server/pull/41636.patch on stable27.

Cases i have tested :

  • Opening internal shared document from Recommended files => OK ( Before patch => NOK )
  • Open Documents created by me in my own Documents folder => OK
  • Open internal shared document from files view => OK
  • Open internal shared document via url => OK ( Before patch => NOK )
  • Open public shared document via url => OK

Note: Sidebar is now closed for all the file open cases mentioned above.

NC version : Nextcloud Hub 6 (27.1.3)
Richdocument : '8.2.3'

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 23, 2023
…andling that

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/only-trigger-sidebar-oce branch from 1803420 to 26b982d Compare November 24, 2023 08:41
@juliusknorr juliusknorr merged commit dc00ecc into stable27 Nov 25, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/only-trigger-sidebar-oce branch November 25, 2023 07:58
@blizzz blizzz mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants