Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Show Collectives icon in Collectives folders #41443

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(files): Show Collectives icon in Collectives folders #41443

merged 2 commits into from
Nov 14, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Nov 13, 2023

Summary

Brings back the Collectives icon to Collectives folders.

Requires #41426.

Screenshot
2023-11-13T18:32:00,950104663+01:00

Checklist

@mejo- mejo- added this to the Nextcloud 28 milestone Nov 13, 2023
artonge
artonge approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs #41426. But should be merged by then :)

@mejo-
Copy link
Member Author

mejo- commented Nov 13, 2023

I don't think it needs #41426. But should be merged by then :)

Not technically, but without it looks pretty ugly 😉

@mejo-
fix(files): Show Collectives icon in Collectives folders
ee5c444 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/f2vue_collectives_folder_icon branch from 61143b8 to ee5c444 Compare November 14, 2023 07:40
@mejo-
Copy link
Member Author

mejo- commented Nov 14, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
effea53 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@tobiasKaminsky tobiasKaminsky merged commit 0e406d9 into master Nov 14, 2023
@tobiasKaminsky tobiasKaminsky deleted the fix/f2vue_collectives_folder_icon branch November 14, 2023 08:44
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@nfebe nfebe Awaiting requested review from nfebe

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug javascript regression
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@mejo- @juliusknorr @artonge @tobiasKaminsky @nextcloud-command