add descriptions for background pictures #41216
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Simon L <szaimen@e.mail.de>
This comment was marked as resolved.
This comment was marked as resolved.
4727864 to
773fe16
Compare
| return [ | ||
| 'hannah-maclean-soft-floral.jpg' => [ | ||
| 'attribution' => $this->l10n->t('Soft floral (Hannah MacLean, CC0)'), | ||
| 'description' => $this->l10n->t('Abstract picture in yellow and white color whith a flower on it'), |
There was a problem hiding this comment.
For reviewers: Please review each description carefully. Does the text look fine?
This reverts commit a6cf2ea.
| @@ -57,7 +58,8 @@ public function __construct(Util $util, | |||
| ImageManager $imageManager, | |||
| IConfig $config, | |||
| IL10N $l, | |||
| IAppManager $appManager) { | |||
| IAppManager $appManager, | |||
| BackgroundService $backgroundService) { | |||
There was a problem hiding this comment.
So this is now breaking many tests (34 afaics). @ChristophWurst Any other idea how I can do this without having to refactor everything? Adding backgroundservice to this constructor at least does not seem to work...
There was a problem hiding this comment.
I don't have any other ideas.
Can you adjust/fix the tests?
There was a problem hiding this comment.
What if I would move the commonthemetrait? Do you think this would make the logic easier?
There was a problem hiding this comment.
Could I ask you to try your changes locally? Using CI for trial and error is really expensive and slows down real builds.
|
Superceded by #41256 |
Close #40689
I added translations for the attributions and added descriptions for each foto.