added CORS skip if session was created by AppAPI

[bigcat88]

Related to: nextcloud/app_api/issues/80

This PR is about for the discussion, how to implement it in a right way.

[bigcat88]

Changes in AppAPI related to this: nextcloud/app_api/pull/81

After merge of this and backport to 27 we can publish AppAPI in the AppStore, and say all is working starting from 27.1.2

[julien-nc]

Maybe we don't need this. We don't have to support non-OCS endpoints in the app ecosystem.
WDYT @AndyScherzinger @nickvergessen ?

[bigcat88]

Just to clarify why I propose to add the support:

1. These all are not OCS, but RestAPI:

• https://nextcloud-bookmarks.readthedocs.io/en/latest/
• https://github.com/nextcloud/notes/blob/main/docs/api/v1.md
• https://nextcloud.github.io/cookbook/dev/api/0.1.0/index.html#/Misc/get_api_v1_config
• https://nextcloud.github.io/news/

2. We can easy add support for them, without breaking any existing stuff(if I didn't miss anything)

[julien-nc]

@bigcat88 You're right, those APIs are not just internal but made to be used by clients. It would be nice to be able to use them in external apps.

[nickvergessen]

Maybe we don't need this. We don't have to support non-OCS endpoints in the app ecosystem.

So yes, the apps should just have provide OCS APIs to begin with. But people follow old tutorials, so this is where we are.

I guess for now it's simpler to add this hack, but I also would prefer to simply require OCS APIs for support.
Maybe we can add a deprecation note into the app developer docs and then simply require OCS routes in a future version (1 year from now?) for app ecosystem support?
Would allow a quick transition for the moment and still ensure good future behaviour?

[blizzz]

master is 28

[bigcat88]

master is 28

why this can not be backported to 27.1.2?

[nickvergessen]

This PR targets master, so the milestone must be what master is which is 28.
Backporting can still be done, and then the backport PR will have a 27.x.y milestone assigned.

[DaphneMuller]

@AndyScherzinger could you perhaps help us with merging this in the right milestone? 27.1.2

[nickvergessen]

could you perhaps help us with merging this in the right milestone? 27.1.2

Just needs the backport bot summoned. Then it will be backported to stable27 and be part of 27.1.3 (.1.2 is already being released at the moment).

But first CI needs fixing:

[nickvergessen]

/backport to stable27

[AndyScherzinger]

@DaphneMuller what @nickvergessen said, so when this is merged (for 28) the already requested backport bot (thanks to nick) will take care of the backport and will also assign the right v27.1.x version number. 👍

[bigcat88]

@DaphneMuller what @nickvergessen said, so when this is merged (for 28) the already requested backport bot (thanks to nick) will take care of the backport and will also assign the right v27.1.x version number. 👍

I thought that this would be for release 27.1.2, because the date in the release calendar for 27.1.2 was in 10 days, not today. I see that the date in the calendar was wrong and has already been corrected.

thank you, we will fix the error that the tests found and it will be by 27.1.3

[bigcat88]

Done. Cypress errors looks unrelated to this, as the same Cypress errors are currently in other PRs.

[nickvergessen]

Cypress errors looks unrelated to this

On this PR all cypress requests fail in "before", so it can't even log in.
Are we sure it's unrelated?

[bigcat88]

Cypress errors looks unrelated to this

On this PR all cypress requests fail in "before", so it can't even log in. Are we sure it's unrelated?

it was unrelated, now CI is green

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport