Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip puppeteer chrome download #40733

Merged
merged 1 commit into from
Nov 1, 2023
Merged

ci: skip puppeteer chrome download #40733

merged 1 commit into from
Nov 1, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 30, 2023 •
edited
Loading

Summary

A eslint job failed last week with:

npm ERR! path /home/runner/actions-runner/_work/server/server/node_modules/puppeteer
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! ERROR: Failed to set up Chrome r115.0.5790.170! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.

Similar to cypress there is no need to download chrome to run eslint / cypress / etc.

TODO

  • CI

Checklist

@kesselb kesselb mentioned this pull request Sep 30, 2023
Merged
@kesselb kesselb self-assigned this Sep 30, 2023
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Sep 30, 2023
max-nextcloud
max-nextcloud approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also makes sense in node.yml and (less important as only run by chron) npm-audit-fix.yml.

@max-nextcloud max-nextcloud force-pushed the enh/noid/puppeteer-skip-download branch from 9c8749d to b24526b Compare October 2, 2023 07:01
@max-nextcloud
Copy link
Contributor

Probably also makes sense in node.yml and (less important as only run by chron) npm-audit-fix.yml.

I rebased and added them.

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2023
@kesselb kesselb force-pushed the enh/noid/puppeteer-skip-download branch from b24526b to acd37ac Compare October 3, 2023 12:21
@susnux susnux force-pushed the enh/noid/puppeteer-skip-download branch from acd37ac to 30c060a Compare October 10, 2023 23:46
@susnux susnux enabled auto-merge October 10, 2023 23:46
@kesselb
Copy link
Contributor Author

kesselb commented Oct 11, 2023

Cypress failure unrelated, please force merge.

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@kesselb
ci: skip puppeteer chrome download
67a761b 
As per https://github.com/puppeteer/puppeteer#installation

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the enh/noid/puppeteer-skip-download branch from 30c060a to 67a761b Compare November 1, 2023 13:11
@susnux susnux merged commit 489624b into master Nov 1, 2023
@susnux susnux deleted the enh/noid/puppeteer-skip-download branch November 1, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @max-nextcloud @susnux @skjnldsv @solracsf