-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable26] SFTP improvements #40521
Merged
Merged
[stable26] SFTP improvements #40521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use phpseclib\Net\SFTP\Stream; | ||
|
||
/** | ||
* Uses phpseclib's Net\SFTP class and the Net\SFTP\Stream stream wrapper to | ||
* provide access to SFTP servers. | ||
*/ | ||
class SFTP extends \OC\Files\Storage\Common { | ||
class SFTP extends Common { |
Check notice
Code scanning / Psalm
DeprecatedInterface
OCP\Files\Storage is marked deprecated
} | ||
} | ||
|
||
public function copy($source, $target) { |
Check notice
Code scanning / Psalm
MissingParamType
Parameter $source has no provided type
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
bc79ff1
to
22237b0
Compare
Merged
artonge
approved these changes
Nov 15, 2023
come-nc
approved these changes
Nov 16, 2023
moving to 26.0.10 |
Merged
CI is dissatisfied |
fixed psalm (kerberos test is known broken in 26 and node seems unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40487