Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip mtime hack for tag search #40422

Closed
wants to merge 1 commit into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 14, 2023

Summary

TODO

  • CI

Checklist

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@miaulalala
Copy link
Contributor

/backport to stable27

@kesselb kesselb requested a review from icewind1991 September 15, 2023 09:47
@kesselb kesselb self-assigned this Sep 15, 2023
@kesselb kesselb added the bug label Sep 15, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Sep 15, 2023
@icewind1991
Copy link
Member

I'm still not convinced that this will lead to better performance in most cases, having mysql use the index for the mtime ORDER (seems to) stop it from using any index for the WHERE clauses.

And while there are certainly cases where this is fine, I believe that in more cases the query gains more performance from being able to use the the index for filtering the storages to search in.

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@kesselb kesselb closed this Nov 1, 2023
@kesselb kesselb deleted the fix/noid/enforce-mtime-index branch November 1, 2023 12:04
@kesselb kesselb removed this from the Nextcloud 28 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants