-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "MFA Verified" check to workflowengine #40235
Add "MFA Verified" check to workflowengine #40235
Conversation
Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com>
Signed-off-by: Michiel de Jong <michiel@pondersource.com>
ee9c992
to
02604be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did not test
apps/workflowengine/lib/Manager.php
Outdated
@@ -759,6 +767,7 @@ | |||
$this->container->query(FileName::class), | |||
$this->container->query(FileSize::class), | |||
$this->container->query(FileSystemTags::class), | |||
$this->container->query(MfaVerified::class), |
Check notice
Code scanning / Psalm
DeprecatedMethod
Signed-off-by: MohammadReza vahedi <mr.vahedi68@gmail.com>
Can this be merged if it looks good? |
@come-nc what is the next step in the process now? |
@ArtificialOwl can you maybe have a look? |
I'm worried about the lack of communication here, @mickenordin can you ask your NC support contact for advice? |
@skjnldsv Thanks for mentioning this PR for NC 28! Will you be the person merging it? Anything we can do to help you? Note that the conflicting files in the dist folders are easy to leave out and then rebuild after you merge! |
@michielbdejong you're missing two reviews. Pinging maintainers nonetheless: @blizzz and @juliushaertl |
With beta from last week, we're behind feature freeze for 28 😧 |
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com> | ||
* | ||
* @author Arthur Schiwon <blizzz@arthur-schiwon.de> | ||
* @author Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* @author Joas Schilling <coding@schilljs.com> | ||
* @author Julius Härtl <jus@bitgrid.net> | ||
* @author Richard Steinmetz <richard@steinmetz.cloud> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
Signed-off-by: Michiel de Jong <michiel@pondersource.com>
Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Signed-off-by: Michiel de Jong <michiel@unhosted.org>
I succeeded in adding this check inside https://github.com/pondersource/mfazones instead of adding it to nextcloud/server, so we can close this PR. If anyone wants to use the |
Rebase of #39471