-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CardDAV): allow disabling of the system address book #39925
Conversation
config:app:set/delete should be sufficient. we don't need dedicated commands right now: https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/occ_command.html#config-commands |
/backport to stable27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like just adding an if
to the above block where the system address book is added in the first place would be much more efficient, why not do that instead?
(in any case, you need to get the getAppValue
call outside of the array_map
so that it doesn't get called for each iteration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine but I didn't check if that has other consequences elsewhere.
52f72b5
to
bb89515
Compare
bb89515
to
cc10db7
Compare
Failing cypress test is unrelated methinks:
|
…ption Signed-off-by: Anna Larch <anna@nextcloud.com>
cc10db7
to
7051f1b
Compare
Applied this patch and everything is working nicely again after disabling the SAB. Thanks a lot! |
I was able to comment out this block of code, and I saw that the "Accounts" address book was no longer exported, as we had hoped. So I am looking forward to the configuration-based fix soon. I did have a question. When this pull request is merged, how would someone set the configuration option? Is it in a config file? Or is there an "occ" command to set the option? Is it eventually stored in the database, or in the code? I imagine this question is a bit outside of the scope of this PR, but it sure would help to have a pointer to how to enable/disable it. Thanks! |
php occ config:app:set dav system_addressbook_exposed --value=no |
Hi, I have a question. Will the deactivation of system address book only be possible via occ-Command or will there be an point in the administration panel? If you have a managed nextcloud, you cannot often work with occ-commands. Best Regards |
Hello, when using the command given in the documentation, I get the following error: I am a bit confused because in the command is no "-a" part |
@exuded Please ask for help on the forum or open your own issue. |
via config option and OCC command
Summary
Allow admins to disable the System Addressbook systemwide.
This might cause complaints from connected clients if the SAB is the default addressbook in their env.
TODO
Checklist