feat(dav): Emit a typed event to deprecate OCA\DAV\Connector\Sabre::addPlugin #39305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tcitworld
reviewed
Jul 11, 2023
8245c21 to
f2edad2
Compare
come-nc
approved these changes
Jul 17, 2023
…ddPlugin Signed-off-by: Joas Schilling <coding@schilljs.com>
f2edad2 to
72667a6
Compare
|
Super nitpick suggestion: Rename SabrePluginAddEvent to SabrePluginAddPluginEvent To use the same "pattern" as for SabrePluginAuthInitEvent ;)
|
kesselb
approved these changes
Jul 18, 2023
kesselb
reviewed
Jul 18, 2023
| // allow setup of additional plugins | ||
| $event = new \OCP\SabrePluginEvent($server); | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); | ||
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); |
There was a problem hiding this comment.
Suggested change
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); | |
| $typedEvent = new \OCA\DAV\Events\SabrePluginAddEvent($server); |
| // allow setup of additional plugins | ||
| $event = new \OCP\SabrePluginEvent($server); | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); | ||
| $event = new \OCA\DAV\Events\SabrePluginAddEvent($server); | ||
| $dispatcher->dispatchTyped($event); |
There was a problem hiding this comment.
Suggested change
| $dispatcher->dispatchTyped($event); | |
| $dispatcher->dispatchTyped($typedEvent); |
I'll pass on this one with: https://docs.nextcloud.com/server/latest/developer_manual/basics/events.html#naming-scheme
|
15 tasks
|
Docs in nextcloud/documentation#10858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist