Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return types #39211

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Add return types #39211

merged 1 commit into from
Sep 9, 2023

Conversation

shdehnavi
Copy link
Contributor

Summary

Add return types to the /themes/defaults.php

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@shdehnavi @artonge
Add return types
1196b5c 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@artonge artonge force-pushed the refactor_themes_defaults branch from 0532ea7 to 1196b5c Compare July 17, 2023 11:29
@juliusknorr juliusknorr merged commit 023d796 into nextcloud:master Sep 9, 2023
@shdehnavi shdehnavi deleted the refactor_themes_defaults branch September 28, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@shdehnavi @nickvergessen @juliusknorr @artonge @solracsf