-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove no longer accessible shares #39168
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also see #39170 for a command that admins can used for manual cleanup instead of automatic cleanup |
Can you show screenshots for current situation on master? |
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
e80c64d
to
b3f529e
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to access a share where the owner no longer has access to the source file, remove the share instead of only marking it as failed.
To test:
A
,B
andC
. Create a groupfolderG
and giveA
andB
access to it.B
uploads a fileF
toG
and shares it withC
A
movesF
outsideG
C
tries to download the fileDownside is that the share is now gone "forever" even if the owner re-gains access to the file. So I'm not sure if this is actually desired behavior
An alternative solution would be to mark the share as unavailable somehow, show the state to the user and make the user choose whether to remove the share or complain to the admin/owner of the file to give him his access back.