Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Trap focus in dialogs #38668

Merged
merged 2 commits into from
Jun 6, 2023
Merged

[stable25] Trap focus in dialogs #38668

merged 2 commits into from
Jun 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 6, 2023 •
edited by artonge
Loading

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #37780

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.8 milestone Jun 6, 2023
@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Jun 6, 2023
@artonge artonge force-pushed the backport/37780/stable25 branch from 91e4224 to 53f50e4 Compare June 6, 2023 13:34
@artonge artonge marked this pull request as ready for review June 6, 2023 13:34
@artonge artonge force-pushed the backport/37780/stable25 branch from 53f50e4 to a8e8c15 Compare June 6, 2023 13:40
@artonge artonge marked this pull request as draft June 6, 2023 13:43
@artonge artonge force-pushed the backport/37780/stable25 branch from a8e8c15 to 1a9e7f6 Compare June 6, 2023 13:49
@artonge artonge marked this pull request as ready for review June 6, 2023 13:50
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Jun 6, 2023
Pytal added 2 commits June 6, 2023 12:42
@Pytal
Add focus-trap
a5222a6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Trap focus in dialogs
056c0a9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the backport/37780/stable25 branch from 1a9e7f6 to 056c0a9 Compare June 6, 2023 19:42
@Pytal Pytal merged commit e9799be into stable25 Jun 6, 2023
@Pytal Pytal deleted the backport/37780/stable25 branch June 6, 2023 22:41
@blizzz blizzz mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 25.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @Pytal @ChristophWurst