Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Comment field's height #38501

Closed

Conversation

Jerome-Herbinet
Copy link
Member

Before

2023-05-29_15-05

Height

2023-05-29_15-10

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet requested a review from skjnldsv May 29, 2023 13:18
@szaimen
Copy link
Contributor

szaimen commented May 29, 2023

I think the better fix would be this: nextcloud-libraries/nextcloud-vue#4163

@Jerome-Herbinet
Copy link
Member Author

I think the better fix would be this: nextcloud/nextcloud-vue#4163

Do you suggest closing this PR now or to wait a bit ?

@szaimen szaimen added the 3. to review Waiting for reviews label May 29, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 29, 2023
@Jerome-Herbinet Jerome-Herbinet mentioned this pull request Aug 31, 2023
4 tasks
@Jerome-Herbinet
Copy link
Member Author

See respawn #40173

@jancborchardt jancborchardt deleted the Jerome-Herbinet-comment-field-height-fix branch August 31, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants