Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] fix(theming): fix header primary invert if background disabled #38433

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[stable25] fix(theming): fix header primary invert if background disabled #38433

merged 1 commit into from
Jun 12, 2023

Conversation

skjnldsv
Copy link
Member

stable26 is already fixed (and above)

Conditions

  • Have global background disabled
  • Have #FFFFFF as global primary colour

Results

Before After
image image

@skjnldsv
fix(theming): fix header primary invert if background disabled
328fa18 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels May 24, 2023
@skjnldsv skjnldsv added this to the Nextcloud 25.0.8 milestone May 24, 2023
@skjnldsv skjnldsv requested a review from a team May 24, 2023 09:46
@skjnldsv skjnldsv self-assigned this May 24, 2023
@skjnldsv skjnldsv requested review from susnux, nfebe and Pytal and removed request for a team May 24, 2023 09:46
@skjnldsv skjnldsv changed the title [stablee25] fix(theming): fix header primary invert if background disabled [stable25] fix(theming): fix header primary invert if background disabled May 24, 2023
@skjnldsv skjnldsv requested a review from artonge May 24, 2023 09:53
@blizzz blizzz mentioned this pull request Jun 12, 2023
Merged
@szaimen szaimen merged commit cf20825 into stable25 Jun 12, 2023
@szaimen szaimen deleted the fix/theming-invert-25 branch June 12, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: theming
Projects
None yet
Milestone
Nextcloud 25.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @artonge @Pytal @szaimen