Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(assets): Require scour 0.38.2 (Ubuntu LTS 22.04+) for SVG optimization #37763

Merged
merged 6 commits into from
Apr 24, 2023
Merged

chore(assets): Require scour 0.38.2 (Ubuntu LTS 22.04+) for SVG optimization #37763

merged 6 commits into from
Apr 24, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 17, 2023 •
edited by solracsf
Loading

Summary

  • Pin scour version minimum
  • Optimize all SVGs
  • Optimize new PNGs and JPGs

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 27 milestone Apr 17, 2023
@nickvergessen nickvergessen self-assigned this Apr 17, 2023
jancborchardt
jancborchardt requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments on 3 images I’m not sure we should touch – otherwise it looks good! :)

@nickvergessen
chore(assets): Require scour 0.38.2 (Ubuntu LTS 22.04+) for SVG optim…
7391881 
…ization

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(assests): Ignore some more directories from optimization
6368032 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(assets): Optimize SVGs with scour 0.38.2
f2afccf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(assets): Optimize PNGs with optipng 0.7.7
db55d5b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(assets): Optimize JPGs with jpegoptim 1.4.7
f82c3d7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/36014/require-scour-0.38.2-for-svg-optimization branch from 7be921d to f82c3d7 Compare April 24, 2023 07:04
ChristophWurst
ChristophWurst approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: squash the commits into one to keep our git history light

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 3. to review Waiting for reviews 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 24, 2023
@nickvergessen
chore(assets): Recompile JS
1917115 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen enabled auto-merge April 24, 2023 08:19
@nickvergessen nickvergessen disabled auto-merge April 24, 2023 09:53
@nickvergessen nickvergessen merged commit 95c0981 into master Apr 24, 2023
@nickvergessen nickvergessen deleted the techdebt/36014/require-scour-0.38.2-for-svg-optimization branch April 24, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@come-nc come-nc come-nc approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

@nickvergessen nickvergessen

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

SVG optimization changes "all" files
4 participants
@nickvergessen @jancborchardt @ChristophWurst @come-nc