More honest reset password request response #37603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valdnet
reviewed
Apr 6, 2023
szaimen
previously requested changes
Apr 6, 2023
artonge
reviewed
Apr 6, 2023
artonge
approved these changes
Apr 6, 2023
Valdnet
approved these changes
Apr 6, 2023
|
Hi @joshtrichards please squash, rebase, run npm ci and npm run build and commit the changes here which will allow us to merge this. Thank you! |
rakekniven
approved these changes
Apr 6, 2023
52691cb to
1a5700d
Compare
Addresses request in additional comments of nextcloud#37408 * Honest but still won't leak information * Also reminds user to verify the provided user id email address/user Signed-off-by: Josh Richards <josh.t.richards@gmail.com> Refine reset password response copy Co-authored-by: Louis <6653109+artonge@users.noreply.github.com> Signed-off-by: Josh Richards <josh.t.richards@gmail.com> Wrap honest password reset request response
1a5700d to
fb25cd4
Compare
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
3f00e28 to
330c9cf
Compare
Done - theoretically. I never got it to pass the GH node workflow check 100% here in the PR (and with my latest push it's waiting on approval to run again). Since the comp'd assets get stashed in the commit it appears the GH node.yml workflow builds them again and diffs them. They always come up different than fail. Is that how it's supposed to work? Am I doing something wrong? Do they get rebuilt again during the final merge on your side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Addresses feedback in additional comments of #37408)
Makes the response provided to users requesting a password reset more honest. Also reminds users to verify the provided account name or email address. Removes redundant copy. Continues to do so without leaking information.
TODO
Checklist