Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore and log non integer versions #37428

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 27, 2023

This avoids being stuck when there is one buggy file version with a
non-numeric version. It allows the expiration process to not crash and
continue with the other ones.

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 27, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Mar 27, 2023
@come-nc come-nc self-assigned this Mar 27, 2023
@come-nc come-nc requested a review from artonge March 27, 2023 15:46
@come-nc come-nc added the bug label Mar 27, 2023
come-nc added 2 commits April 5, 2023 17:44
This avoids being stuck when there is one buggy file version with a
 non-integer version. It allows the expiration process to not crash and
 continue with the other ones.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
All versions are string

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/ignore-non-numeric-versions branch from e53b549 to a6b1d99 Compare April 5, 2023 15:50
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team April 5, 2023 15:52
@blizzz
Copy link
Member

blizzz commented Apr 5, 2023

This avoids being stuck when there is one buggy file version with a
non-numeric version.

What's the root cause?

@come-nc
Copy link
Contributor Author

come-nc commented Apr 17, 2023

This avoids being stuck when there is one buggy file version with a
non-numeric version.

What's the root cause?

No idea, might be moving file to/from groupfolders, or a buggy application.
This is to help debugging this case and not have the whole version expiry system crash down because of one badly named file.

@come-nc come-nc merged commit 60b7d21 into master Apr 20, 2023
@come-nc come-nc deleted the enh/ignore-non-numeric-versions branch April 20, 2023 11:34
@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2023

/backport to stable26

@solracsf
Copy link
Member

solracsf commented Jul 3, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc
Copy link
Contributor Author

come-nc commented Jul 3, 2023

/backport to stable27

It’s already in 27

@come-nc come-nc removed this from the Nextcloud 28 milestone Jul 3, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants