-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2FA blocks' width on login screen #37380
Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
CI failure unrelated |
Thanks for merging @artonge :-) |
Have you checked if the issue is also there? |
/backport to stable26 |
/backport to stable25 |
/backport to stable24 |
Hmm, honestly not ... |
Can you check ? I do not want to blindly backport if the issue is not there, as it could create an issue where there wasn't any. I would be fine with not backporting. |
Of course, I agree with you. In fact, the problem first occurs in NC25 (noticed in my private instance ... and that's why I opened this issue). I just made tests on other NC versions :
I think the problem started to occur with the new NC25 design. |
Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com
Summary
Fixes this UI problem by replacing a fixed with (px) with a secure 100% (flexible) with :
... so if the parent width changes (currently max-width: 290px), the 2FA blocks will still have a correct adaptive width.
TODO
Checklist