Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2FA blocks' width on login screen #37380

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

  • Resolves: #

Summary

Fixes this UI problem by replacing a fixed with (px) with a secure 100% (flexible) with :

2023-03-24_10-17

... so if the parent width changes (currently max-width: 290px), the 2FA blocks will still have a correct adaptive width.

TODO

  • ...

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet changed the title Fix 2FA blocks' width Fix 2FA blocks' width on login screen Mar 24, 2023
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen added the 3. to review Waiting for reviews label Mar 24, 2023
@szaimen szaimen requested review from a team, artonge, skjnldsv and Pytal and removed request for a team March 24, 2023 09:33
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 24, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

CI failure unrelated

@artonge artonge enabled auto-merge March 27, 2023 09:45
@artonge artonge disabled auto-merge March 27, 2023 09:45
@artonge artonge merged commit 130440e into nextcloud:master Mar 27, 2023
@Jerome-Herbinet
Copy link
Member Author

Thanks for merging @artonge :-)
Could this be backported to the next minor updates of NC 24 25 26 ?

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

Could this be backported to the next minor updates of NC 24 25 26 ?

Have you checked if the issue is also there?

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

/backport to stable26

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

/backport to stable25

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

/backport to stable24

@Jerome-Herbinet
Copy link
Member Author

Could this be backported to the next minor updates of NC 24 25 26 ?

Have you checked if the issue is also there?

Hmm, honestly not ...

@artonge
Copy link
Contributor

artonge commented Mar 27, 2023

Hmm, honestly not ...

Can you check ? I do not want to blindly backport if the issue is not there, as it could create an issue where there wasn't any.

I would be fine with not backporting.

@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Mar 27, 2023

Hmm, honestly not ...

Can you check ? I do not want to blindly backport if the issue is not there, as it could create an issue where there wasn't any.

I would be fine with not backporting.

Of course, I agree with you.

In fact, the problem first occurs in NC25 (noticed in my private instance ... and that's why I opened this issue).

I just made tests on other NC versions :

  • NC 24 : no problem
  • NC 26 : problem, similar to NC25

I think the problem started to occur with the new NC25 design.

@backportbot-nextcloud

This comment was marked as off-topic.

@backportbot-nextcloud

This comment was marked as off-topic.

@backportbot-nextcloud

This comment was marked as off-topic.

@Jerome-Herbinet Jerome-Herbinet deleted the patch-15 branch August 29, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants