Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix/36908 set aria hidden for default shipped widgets icons #37337

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[stable25] Fix/36908 set aria hidden for default shipped widgets icons #37337

merged 1 commit into from
Mar 24, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 22, 2023 •
edited
Loading

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #37271

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 22, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Mar 22, 2023
@JuliaKirschenheuter
Fix description for icons in dashboard widgets
2d49d8a 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

(cherry picked from commit b111c18)
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36908-set_aria-hidden-for-default-shipped_widgets-icons-stable25 branch from dc76046 to 2d49d8a Compare March 24, 2023 08:21
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish accessibility and removed 3. to review Waiting for reviews labels Mar 24, 2023
@JuliaKirschenheuter JuliaKirschenheuter merged commit 83aef8e into stable25 Mar 24, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36908-set_aria-hidden-for-default-shipped_widgets-icons-stable25 branch March 24, 2023 09:43
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Mar 24, 2023
Closed
3 tasks
@skjnldsv skjnldsv mentioned this pull request Apr 13, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaKirschenheuter @artonge @skjnldsv @ChristophWurst