Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): Mark recording_servers key appconfig as private as it … #37334

Conversation

nickvergessen
Copy link
Member

…contains a secret

occ config:list spreed

Before

{
    "apps": {
        "spreed": {
            "enabled": "yes",
            "installed_version": "17.0.0-dev",
            "recording_servers": "{\"servers\":[{\"server\":\"http:\/\/172.17.0.3:8000\",\"verify\":false}],\"secret\":\"OMGmySECRETwasLEAKED\"}",
            "signaling_dev": "yes",
            "signaling_servers": "***REMOVED SENSITIVE VALUE***",
            "signaling_token_privkey_es256": "***REMOVED SENSITIVE VALUE***",
            "signaling_token_pubkey_es256": "***REMOVED SENSITIVE VALUE***",
            "sip_bridge_dialin_info": "***REMOVED SENSITIVE VALUE***",
            "sip_bridge_shared_secret": "***REMOVED SENSITIVE VALUE***",
            "types": "dav,prevent_group_restriction"
        }
    }
}

After

{
    "apps": {
        "spreed": {
            "enabled": "yes",
            "installed_version": "17.0.0-dev",
            "recording_servers": "***REMOVED SENSITIVE VALUE***",
            "signaling_dev": "yes",
            "signaling_servers": "***REMOVED SENSITIVE VALUE***",
            "signaling_token_privkey_es256": "***REMOVED SENSITIVE VALUE***",
            "signaling_token_pubkey_es256": "***REMOVED SENSITIVE VALUE***",
            "sip_bridge_dialin_info": "***REMOVED SENSITIVE VALUE***",
            "sip_bridge_shared_secret": "***REMOVED SENSITIVE VALUE***",
            "types": "dav,prevent_group_restriction"
        }
    }
}

Checklist

…contains a secret

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Mar 22, 2023
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone Mar 22, 2023
@nickvergessen nickvergessen requested a review from a team March 22, 2023 08:18
@nickvergessen nickvergessen self-assigned this Mar 22, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl, icewind1991 and come-nc and removed request for a team March 22, 2023 08:18
@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen nickvergessen merged commit 014a634 into master Mar 22, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/mark-recording-servers-as-sensitive-due-to-secret branch March 22, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants