fix(user_status): Fix the user status automation on the day availablity rules are adjusted #36852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
Merged
4 tasks
| @@ -92,7 +92,7 @@ | |||
| $isCurrentlyAvailable = false; | |||
| $nextPotentialToggles = []; | |||
|
|
|||
| $now = new \DateTime('now'); | |||
| $now = $this->time->getDateTime(); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod
…ity rules are adjusted Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
2e431a0 to
c7400fa
Compare
tcitworld
approved these changes
Mar 13, 2023
|
/backport to stable26 |
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was trying to work towards #29339 but the availability I configured did not kick in and set myself to DND
So after lengthy debugging it turns out we need to do some shenanigans to fix the automation on the day the rules were adjusted
Otherwise the $originalStart would match rules for Thursdays on a Friday, etc. So we simply wind back a week and then fastForward to the next occurrence since today's midnight, which then also accounts for the week days.
Checklist