Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create headings for apps, users, settings pages #36640

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 9, 2023

Summary

Create headings for settings, users and apps pages. No visible changes.

After

Screenshot from 2023-02-13 15-45-16
Screenshot from 2023-02-13 15-45-45

Checklist

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 1c57a68 to 0f73b90 Compare February 10, 2023 13:06
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Feb 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Feb 10, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review February 10, 2023 13:25
@JuliaKirschenheuter JuliaKirschenheuter changed the title Fix/35626 no heading nor tab index for settings pages Fix/35626 no heading nor tab index for apps, users, settings pages Feb 10, 2023
apps/settings/src/router.js Outdated Show resolved Hide resolved
core/templates/layout.user.php Outdated Show resolved Hide resolved
core/templates/layout.user.php Outdated Show resolved Hide resolved
core/templates/layout.user.php Outdated Show resolved Hide resolved
@JuliaKirschenheuter JuliaKirschenheuter changed the title Fix/35626 no heading nor tab index for apps, users, settings pages Create headings for apps, users, settings pages Feb 13, 2023
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft February 13, 2023 14:44
@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 13, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch 3 times, most recently from 5380d0f to 2ab6bc3 Compare March 2, 2023 10:36
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review March 2, 2023 10:36
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 2, 2023
apps/settings/src/router.js Outdated Show resolved Hide resolved
core/src/OCP/accessibility.js Outdated Show resolved Hide resolved
core/src/OCP/accessibility.js Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 2, 2023
@ChristophWurst
Copy link
Member

The new OCP.Accessibility function should go into the developer documentation

@nickvergessen nickvergessen removed their request for review March 3, 2023 11:37
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

core/src/OCP/accessibility.js Outdated Show resolved Hide resolved
core/src/OCP/accessibility.js Show resolved Hide resolved
core/templates/layout.user.php Outdated Show resolved Hide resolved
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch 2 times, most recently from 4253177 to c73c945 Compare March 6, 2023 11:48
@ChristophWurst
Copy link
Member

Let's stick with fixups until the second approval and passing CI (with the exception of the fixup check)

Bildschirmfoto vom 2023-03-06 13-07-07

^ makes it very hard to follow your latest pushes

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, else it looks good :)

core/src/OCP/accessibility.js Outdated Show resolved Hide resolved
@nickvergessen nickvergessen removed their request for review March 6, 2023 16:33
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 0a5e835 to daae060 Compare March 7, 2023 16:12
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] No heading for settings pages
6 participants