Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Install composer dependencies of Talk #36389

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

nickvergessen
Copy link
Member

  • Resolves: N/A

Summary

Ref nextcloud/spreed#8578
Found in #36310 (comment)

Checklist

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not happy:

+ composer install --no-dev
/bin/sh: composer: not found

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@ChristophWurst
Copy link
Member

you can also use ci as prefix for conventional commits. tools that generate changelogs would then hide the commit. a fix would be listed as a fix on the product. end of nitpick.

@nickvergessen
Copy link
Member Author

So, we are green and good again :)

@nickvergessen nickvergessen merged commit af5910b into master Jan 27, 2023
@nickvergessen nickvergessen deleted the nickvergessen-patch-1 branch January 27, 2023 09:29
@kesselb kesselb mentioned this pull request Jan 27, 2023
9 tasks
@blizzz blizzz mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants