Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keyup enter in user status #36121

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Allow keyup enter in user status #36121

merged 2 commits into from
Jan 13, 2023

Conversation

nickvergessen
Copy link
Member

  • Resolves: #

Summary

  • Use an ibus keyboard extension to e.g. write chinese/japanese/emoji characters
  • Try to use them in user status, e.g. switch to emoji keyboard type dog and then enter to select the emoji
  • While with emojis it's a luxury problem, with unicodes it's so disruptive rendering the feature almost useless. You have to type the status outside and copy paste it there, or open the modal again after each. and. every. character.

Screenshots

Before After
Modal closes Modal stays open and cursor is behind the emoji
🚫 grafik

Checklist

@nickvergessen
fix(user_status): Allow to use enter to complete characters without a…
5506229 
…utomatically closing the modal

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(js): Recompile
19aa254 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Jan 12, 2023
@nickvergessen nickvergessen requested review from PVince81, skjnldsv, a team and Pytal and removed request for a team January 12, 2023 16:12
@nickvergessen
Copy link
Member Author

/backport 5506229 to stable25

PVince81
PVince81 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine with fcitx (another input method like ibus): hitting enter while in the input method doesn't close the dialog any more

also hitting enter while in the input field still submits the dialog

👍

@skjnldsv skjnldsv merged commit 62476a3 into master Jan 13, 2023
@skjnldsv skjnldsv deleted the bugfix/noid/allow-keyup-enter-in-user-status branch January 13, 2023 06:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 13, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 13, 2023
Merged
1 task
@skjnldsv
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 14, 2023 •
edited by Pytal
Loading

The backport to stable25 failed. Please do this backport manually.

#36415

@skjnldsv
Copy link
Member

Rah

@nickvergessen
Copy link
Member Author

I'll take care after the release. Added a deck card to my todo

This was referenced Jan 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: status
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @skjnldsv @PVince81