Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(OCP): Remove deprecated dashboard interfaces and classes #35966

Merged
merged 1 commit into from
Jan 10, 2023
Merged

chore(OCP): Remove deprecated dashboard interfaces and classes #35966

merged 1 commit into from
Jan 10, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 3, 2023 •
edited
Loading

Summary

The old dashboard API interfaces and classes have been deprecated since Nextcloud 20 (older than 2 years and 6 releases) so we can drop those for 26 as they have been directly replaced with Nextcloud 20 with the new API.

Checklist

@juliusknorr juliusknorr requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team January 3, 2023 16:31
@juliusknorr juliusknorr force-pushed the chore/remove-deprecated-dashboard branch 2 times, most recently from e56d0bd to b02955a Compare January 3, 2023 16:58
@juliusknorr
chore(OCP): Remove deprecated dashboard interfaces and classes
5b67b92 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the chore/remove-deprecated-dashboard branch from b02955a to 5b67b92 Compare January 3, 2023 19:18
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 3, 2023
PVince81
PVince81 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from artonge and come-nc January 9, 2023 14:19
@juliusknorr juliusknorr merged commit 32e691f into master Jan 10, 2023
@juliusknorr juliusknorr deleted the chore/remove-deprecated-dashboard branch January 10, 2023 11:08
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jan 10, 2023
@nickvergessen
Copy link
Member

Should be documented in #34692

@DaphneMuller
Copy link

hello @come-nc
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

@juliusknorr juliusknorr mentioned this pull request Feb 21, 2023
Closed
@juliusknorr
Copy link
Member Author

Added to #34692 accordingly

@juliusknorr juliusknorr removed the pending documentation This pull request needs an associated documentation update label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@juliusknorr @nickvergessen @DaphneMuller @PVince81 @come-nc @szaimen