Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the LoginController strict #35784

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Make the LoginController strict #35784

merged 1 commit into from
Dec 16, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 15, 2022 •
edited
Loading

Resolves: N/a

Summary

Strict types are love. Strict types are life.

TODO

  • Enable strict types
  • Fix type errors

Checklist

@ChristophWurst
chore: Make the LoginController strict
138deec 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Dec 15, 2022
@ChristophWurst ChristophWurst self-assigned this Dec 15, 2022
miaulalala
miaulalala approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 15, 2022
@ChristophWurst
Copy link
Member Author

CI failures caused by #35621 and therefore unrelated

@julien-nc julien-nc mentioned this pull request Dec 15, 2022
Merged
@PVince81 PVince81 merged commit 6737dea into master Dec 16, 2022
@PVince81 PVince81 deleted the chore/strict-login-controller branch December 16, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@miaulalala miaulalala miaulalala approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@vitormattos vitormattos Awaiting requested review from vitormattos

@jbarnoin jbarnoin Awaiting requested review from jbarnoin

@julien-nc julien-nc Awaiting requested review from julien-nc

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @miaulalala @PVince81