Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bottom margin of shared pdfviewer links #3568

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Conversation

jancborchardt
Copy link
Member

Before & after:
capture du 2017-02-21 19-56-10
Note the double scrollbar and white bottom margin there ^

capture du 2017-02-21 19-56-49

Please review @nextcloud/designers

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Feb 21, 2017
@jancborchardt jancborchardt added this to the Nextcloud 12.0 milestone Feb 21, 2017
@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv to be a potential reviewer.

@codecov-io
Copy link

Codecov Report

Merging #3568 into master will increase coverage by 0.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3568      +/-   ##
============================================
+ Coverage     54.28%   54.71%   +0.43%     
- Complexity    21061    21445     +384     
============================================
  Files          1310     1310              
  Lines         80354    81626    +1272     
  Branches       1250     1250              
============================================
+ Hits          43621    44663    +1042     
- Misses        36733    36963     +230
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Proxy.php 35.1% <ø> (-13.43%) 29% <ø> (+8%)
lib/private/Files/Cache/Wrapper/CacheJail.php 85% <ø> (-2.35%) 54% <ø> (+18%)
lib/private/Setup.php 12.88% <ø> (-0.12%) 49% <ø> (ø)
apps/files_external/lib/Command/Notify.php 0% <ø> (ø) 37% <ø> (ø)
settings/templates/users/main.php 0% <ø> (ø) 0% <ø> (ø)
lib/private/Federation/CloudIdManager.php 100% <ø> (ø) 27% <ø> (+12%)
apps/federatedfilesharing/lib/Notifier.php 0% <ø> (ø) 25% <ø> (+1%)
apps/files/lib/AppInfo/Application.php 0% <ø> (ø) 2% <ø> (ø)
lib/private/Server.php 92.78% <ø> (+0.17%) 120% <ø> (ø)
apps/files_external/lib/Lib/Storage/SMB.php 47.22% <ø> (+0.39%) 112% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d754227...afed96e. Read the comment docs.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Works 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Works 👍

@MorrisJobke MorrisJobke merged commit 577adf0 into master Feb 21, 2017
@MorrisJobke MorrisJobke deleted the fix-pdfviewer-margin branch February 21, 2017 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants