-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bottom margin of shared pdfviewer links #3568
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv to be a potential reviewer. |
Codecov Report
@@ Coverage Diff @@
## master #3568 +/- ##
============================================
+ Coverage 54.28% 54.71% +0.43%
- Complexity 21061 21445 +384
============================================
Files 1310 1310
Lines 80354 81626 +1272
Branches 1250 1250
============================================
+ Hits 43621 44663 +1042
- Misses 36733 36963 +230
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Works 👍
Before & after:

Note the double scrollbar and white bottom margin there ^
Please review @nextcloud/designers