-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sharing expiration date handling and saving #35207
Conversation
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks but fine otherwise :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my testing. However here we need to add date +1 since otherwise the default will not work as the current date is already reached.
defaultExpirationDate = new Date() |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e03248e
to
bfa378f
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
bfa378f
to
2b4ce7b
Compare
Pushed and ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt test again but I trust you that it works now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works 👍
Doesn't seems related, also failed on previous merges to master |
Regression from #33915
Fix #34926
Explanations
share.expireDate
represent the Database expiration data. Which expects aYYYY-MM-DD
formatDate
as valueserver/apps/files_sharing/lib/Controller/ShareAPIController.php
Line 236 in 62919ac
server/apps/files_sharing/src/mixins/SharesMixin.js
Lines 161 to 162 in e03248e