-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu elements not displayed as block #34886
Conversation
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
/backport to stable25 |
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
From my testing this would reintroduce #33857 So I suggest we restore the deleted snippet and scope it like ...
.popovermenu {
&:not(.fileActionsMenu) {
li {
> button,
> a,
> .menuitem {
width: fit-content;
/* DEPRECATED! old img in popover fallback
* TODO: to remove */
> img {
width: $popoveritem-height;
height: $popoveritem-height;
}
}
}
}
}
... The DEPRECATED part introduced in #11054 doesn't seem to apply anymore, at least in the files sharing sidebar, but would need @danxuliu to confirm |
@nextcloud/server-frontend how to continue with this? |
I'd vote for Chris' proposal. @Pytal can you take this over? :) |
@skjnldsv please take over |
Ping @skjnldsv ? :) |
hm... I just tried the latest 25 with
And I somehow cannot reproduce the problem. It seems to work... But really no idea what has fixed it... |
Close #34653
Close #35153
Fix for #34870 to set the width to 100% for all elements.