Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu elements not displayed as block #34886

Closed
wants to merge 4 commits into from
Closed

Conversation

Dennis1993
Copy link
Contributor

@Dennis1993 Dennis1993 commented Oct 30, 2022

Close #34653
Close #35153

Fix for #34870 to set the width to 100% for all elements.

Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
@Dennis1993 Dennis1993 changed the title Dennis1993 patch 1 Menu elements not display block Oct 30, 2022
@Dennis1993 Dennis1993 changed the title Menu elements not display block Menu elements not displayed as block Oct 30, 2022
@Dennis1993 Dennis1993 added this to the Nextcloud 25.0.1 milestone Oct 30, 2022
@Dennis1993 Dennis1993 added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 30, 2022
@szaimen szaimen requested review from a team, PVince81, skjnldsv and szaimen and removed request for a team October 30, 2022 16:55
@szaimen
Copy link
Contributor

szaimen commented Oct 30, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Oct 30, 2022

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal
Copy link
Member

Pytal commented Nov 2, 2022

From my testing this would reintroduce #33857

So I suggest we restore the deleted snippet and scope it like

...
	.popovermenu {
		&:not(.fileActionsMenu) {
			li {
				> button,
				> a,
				> .menuitem {
					width: fit-content;
					/* DEPRECATED! old img in popover fallback
					* TODO: to remove */
					> img {
						width: $popoveritem-height;
						height: $popoveritem-height;
					}
				}
			}
		}
	}
...

The DEPRECATED part introduced in #11054 doesn't seem to apply anymore, at least in the files sharing sidebar, but would need @danxuliu to confirm

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

@nextcloud/server-frontend how to continue with this?

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2022

I'd vote for Chris' proposal.

@Pytal can you take this over? :)

@PVince81
Copy link
Member

@skjnldsv please take over

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Ping @skjnldsv ? :)

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

Ping @skjnldsv ? :)

I could also do this if we agree that @Pytal's suggestion is the way to go :)

@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

hm... I just tried the latest 25 with

docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
-e SERVER_BRANCH=stable25 \
-e RIGHTCLICK_BRANCH=stable25 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

And I somehow cannot reproduce the problem. It seems to work...

But really no idea what has fixed it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
6 participants