-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port files_versions to vue #34769
Port files_versions to vue #34769
Conversation
6b15d21
to
c2276f1
Compare
is the border shadow around the thumbnail on purpose ? are we using this style elsewhere ? is it on purpose that the row buttons are more blue-ish than the ones in the header ? |
Yeah I added them because otherwise the preview is just looking really weird for any text document (and files versions is primarely used for text documents) Alternative we could add either a more subtle shadow or a simple border @jancborchardt @nimishavijay what do you think?
It's using secondary action type and not the ternary action type, not sure what is the appropriate here as we don't have any guidelines documented somewhere :( |
8d425cc
to
90023c6
Compare
90023c6
to
2bb7385
Compare
@CarlSchwan no problem, that's what we have Drop shadow here does not really make sense as nothing is elevated. :) That is, the text linked with the preview would not have a drop shadow either. |
A few eslint issues to fix :) |
changed to a simple border :) and I updated the PR description with the latest visual |
052e53c
to
edf1f38
Compare
edf1f38
to
0118d60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the logger comment, feel free to ignore the others as they are not crucial :)
@artonge added comments :) |
c5a7016
to
b094abd
Compare
Simplify code and make it use our standard components Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
b094abd
to
9d54b60
Compare
Rebased. Will merge when CI is green |
Simplify code and make it use our standard components, will be helpful when adding more features in the future
After