Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Bump @nextcloud/password-confirmation from 4.0.1 to 4.0.2 #34590

Merged
merged 2 commits into from
Oct 19, 2022
Merged

[stable25] Bump @nextcloud/password-confirmation from 4.0.1 to 4.0.2 #34590

merged 2 commits into from
Oct 19, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 13, 2022 •
edited
Loading

Backport #34541

Fix #34611

@Pytal Pytal added the 3. to review Waiting for reviews label Oct 13, 2022
@Pytal Pytal added this to the Nextcloud 25.0.1 milestone Oct 13, 2022
@Pytal Pytal self-assigned this Oct 13, 2022
@Pytal Pytal mentioned this pull request Oct 13, 2022
Merged
nickvergessen
nickvergessen approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the broken admin password confirmation qualifies for a merge into 25.0.0 thou.
Will be super inconvenient, but a workaround (pressing enter) is there, so maybe 25.0.1 is good enough.

@blizzz blizzz mentioned this pull request Oct 14, 2022
Merged
1 task
@Pytal Pytal mentioned this pull request Oct 14, 2022
Closed
9 tasks
@skjnldsv
Copy link
Member

/rebase

@blizzz blizzz mentioned this pull request Oct 17, 2022
Merged
@szaimen szaimen mentioned this pull request Oct 18, 2022
Closed
9 tasks
@PVince81
Copy link
Member

@Pytal needs manual rebase with conflict resolution

Pytal added 2 commits October 19, 2022 17:18
@Pytal
Bump @nextcloud/password-confirmation from 4.0.1 to 4.0.2
6fe73ae 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 4d306fc)
@Pytal
Fix empty password string being submitted to server
adbaff7 
- Fix reveal password not working

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit dbaf8f3)
@Pytal Pytal force-pushed the backport/34541/stable25 branch from fc8869f to adbaff7 Compare October 19, 2022 17:20
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 19, 2022
@Pytal Pytal merged commit 372db92 into stable25 Oct 19, 2022
@Pytal Pytal deleted the backport/34541/stable25 branch October 19, 2022 18:35
@Pytal Pytal mentioned this pull request Oct 19, 2022
Closed
@szaimen szaimen mentioned this pull request Oct 20, 2022
Closed
9 tasks
@AndyXheli AndyXheli mentioned this pull request Oct 25, 2022
Closed
9 tasks
@AndyXheli
Copy link

#34782

@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @skjnldsv @PVince81 @AndyXheli @nickvergessen