-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primary color presets for shipped backgrounds #34272
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
master is 26, please trigger backport if necessary. |
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about custom backgrounds?
Let's split things :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and the colors do not seem to get applied. am I doing something wrong or is the logic not in place, yet?
Seems liek the logic is not here yet |
Was meant to be a micro PR for quick approval with the logic being added separately :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was meant to be a micro PR for quick approval with the logic being added separately :)
Ah, sorry, I didn't thought you would split that much! 🙈
@Pytal I fear ai cannot check if the colors match and look good without the logic in place... |
Pre-checked by @jancborchardt which is better than AI ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘 then ;)
Add presets for #33925