Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also apply top margin to audio in firefox #34068

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

max-nextcloud
Copy link
Contributor

Based on nextcloud/viewer#1371 .

If we are displaying an audio file in a single page share provide enough margin to display the speed settings.

Follow up to #34055 .

Based on nextcloud/viewer#1371 .
If we are displaying an audio file in a single page share
provide enough margin to display the speed settings.

Signed-off-by: Max <max@nextcloud.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@szaimen szaimen added this to the Nextcloud 25 milestone Sep 14, 2022
@szaimen szaimen enabled auto-merge September 14, 2022 09:46
@szaimen szaimen disabled auto-merge September 14, 2022 10:59
@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

CI failure unrelated

@szaimen szaimen merged commit 9796524 into master Sep 14, 2022
@szaimen szaimen deleted the fix/only-apply-margin-to-audio branch September 14, 2022 10:59
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants