Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase spacing between additional sharing tab content sections #34043

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Increase spacing between additional sharing tab content sections #34043

merged 1 commit into from
Sep 13, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 13, 2022 •
edited
Loading

Suggested by @jancborchardt

Before After
image image
  • Enough whitespace to the top to separate from sharing

@Pytal
Increase spacing between additional sharing tab content
ccc8316 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 13, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Sep 13, 2022
@Pytal Pytal requested review from jancborchardt and a team September 13, 2022 02:12
@Pytal Pytal self-assigned this Sep 13, 2022
@Pytal Pytal requested review from PVince81, artonge and skjnldsv and removed request for a team September 13, 2022 02:12
@Pytal Pytal mentioned this pull request Sep 13, 2022
Closed
PVince81
PVince81 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit dacd181 into master Sep 13, 2022
@PVince81 PVince81 deleted the enh/sharing-tab-additional-content-spacing branch September 13, 2022 08:30
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @PVince81 @szaimen