Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use filesystem user instead of file owner for creating version #34001

Merged
merged 1 commit into from
Sep 12, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/files_versions/lib/Storage.php
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,18 @@ public static function store($filename) {
$ownerNodes = $ownerFolder->getById($file->getId());
if (count($ownerNodes)) {
$file = current($ownerNodes);
$uid = $mount->getShare()->getShareOwner();
}
}

/** @var IUserManager $userManager */
$userManager = \OC::$server->get(IUserManager::class);
$user = $userManager->get($uid);

if (!$user) {
return false;
}

// no use making versions for empty files
if ($file->getSize() === 0) {
return false;
Expand All @@ -227,7 +236,7 @@ public static function store($filename) {
/** @var IVersionManager $versionManager */
$versionManager = \OC::$server->get(IVersionManager::class);

$versionManager->createVersion($file->getOwner(), $file);
$versionManager->createVersion($user, $file);
}


Expand Down