Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay getting the home dir of a user untill needed #33597

Closed
wants to merge 1 commit into from
Closed

delay getting the home dir of a user untill needed #33597

wants to merge 1 commit into from

Conversation

icewind1991
Copy link
Member

for cache-only operations we don't actually need to know the home directory

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 18, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Aug 18, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, skjnldsv and CarlSchwan and removed request for a team August 18, 2022 09:31
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2022
Merged
PVince81
PVince81 reviewed Aug 23, 2022
View reviewed changes
lib/private/Files/Storage/Home.php
}

public function getSourcePath($path) {
if ($this->datadir == '/tmp/empty/placeholder/') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a constant ?

should we use a value even more cryptic ?

This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
PVince81
PVince81 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

conflict

@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
@icewind1991 icewind1991 force-pushed the home-storage-lazy-datadir branch 2 times, most recently from 4c996f6 to c931399 Compare September 16, 2022 15:08
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@PVince81
Copy link
Member

PVince81 commented Nov 4, 2022

/rebase

@icewind1991 @PVince81
delay getting the home dir of a user untill needed
612b2a4 
for cache-only operations we don't actually need to know the home directory

Signed-off-by: Robin Appelman <robin@icewind.nl>
@nextcloud-command nextcloud-command force-pushed the home-storage-lazy-datadir branch from c931399 to 612b2a4 Compare November 4, 2022 17:21
@PVince81
Copy link
Member

PVince81 commented Nov 7, 2022 


There was 1 failure:

1) Test\User\UserTest::testDeleteWithDifferentHome
Expectation failed for method name is "implementsActions" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

@blizzz blizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@icewind1991 please fix the test

This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv deleted the home-storage-lazy-datadir branch August 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
2. developing Work in progress performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icewind1991 @PVince81 @szaimen @CarlSchwan @blizzz @skjnldsv