Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle one time password better #33225

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Handle one time password better #33225

merged 1 commit into from
Jul 29, 2022

Conversation

CarlSchwan
Copy link
Member

Continuation of #33110

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jul 13, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Jul 13, 2022
@CarlSchwan CarlSchwan requested a review from a team July 13, 2022 13:29
@CarlSchwan CarlSchwan self-assigned this Jul 13, 2022
@CarlSchwan CarlSchwan requested review from PVince81, icewind1991 and blizzz and removed request for a team July 13, 2022 13:29
PVince81
PVince81 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 19, 2022
@blizzz
Copy link
Member

blizzz commented Jul 19, 2022

  1. Test\Authentication\Token\PublicKeyTokenProviderTest::testUpdatePasswords
    --
    Expectation failed for method name is "getTokenByUser" when invoked 1 time(s).
    Method was expected to be called 1 times, actually called 0 times.

@blizzz blizzz added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jul 19, 2022
@CarlSchwan CarlSchwan force-pushed the fix/handle-one-time-passwords branch from 100c05d to 4998967 Compare July 26, 2022 08:42
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 26, 2022
@PVince81
Copy link
Member

likely related failure:

1) Test\Authentication\Token\PublicKeyTokenProviderTest::testGenerateTokenNoPassword
Failed asserting that exception of type "OC\Authentication\Exceptions\PasswordlessTokenException" is thrown.

@PVince81 PVince81 added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jul 26, 2022
@CarlSchwan
Handle one time password better
702445b 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the fix/handle-one-time-passwords branch from 4998967 to 702445b Compare July 28, 2022 12:26
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 28, 2022
@CarlSchwan CarlSchwan merged commit 952acd4 into master Jul 29, 2022
@CarlSchwan CarlSchwan deleted the fix/handle-one-time-passwords branch July 29, 2022 10:26
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
@come-nc come-nc mentioned this pull request Dec 13, 2022
Closed
1 task
@CarlSchwan CarlSchwan mentioned this pull request Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlSchwan @blizzz @PVince81