Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39 #32859

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39 #32859

merged 1 commit into from
Oct 11, 2022

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 13, 2022

Fix #31973

Someone added a file config/mimetypealiases.json to my instance like below. Key is empty hence the check if the first character of the string is _ fails.

{
	"": "x-office\/document",
	"application\/vnd.openxmlformats-officedocument.wordprocessingml.document.docxf": "x-office\/document",
	"application\/vnd.openxmlformats-officedocument.wordprocessingml.document.oform": "x-office\/document"
}

@kesselb kesselb force-pushed the bug/31973/array-key-might-be-empty branch from 3c09020 to 19a7c84 Compare June 13, 2022 10:03
@kesselb kesselb added bug 2. developing Work in progress labels Jun 13, 2022
@kesselb kesselb self-assigned this Jun 13, 2022
@kesselb kesselb force-pushed the bug/31973/array-key-might-be-empty branch 2 times, most recently from 2eac3fd to d595013 Compare June 14, 2022 13:10
@kesselb
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
6f3ab2f 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/31973/array-key-might-be-empty branch from d595013 to 6f3ab2f Compare June 28, 2022 13:45
@kesselb kesselb requested review from CarlSchwan and come-nc June 28, 2022 13:50
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 28, 2022
@solracsf solracsf added this to the Nextcloud 25 milestone Sep 24, 2022
@blizzz blizzz mentioned this pull request Sep 27, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 27, 2022
come-nc
come-nc approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to have an empty string as a valid key is $aliases array though?

@kesselb
Copy link
Contributor Author

kesselb commented Oct 10, 2022

Is it expected to have an empty string as a valid key is $aliases array though?

I don't think so ;)

@artonge artonge merged commit e4d3344 into master Oct 11, 2022
@artonge artonge deleted the bug/31973/array-key-might-be-empty branch October 11, 2022 09:15
@come-nc
Copy link
Contributor

come-nc commented Oct 11, 2022

/backport to stable25

@come-nc
Copy link
Contributor

come-nc commented Oct 11, 2022

/backport to stable24

@come-nc
Copy link
Contributor

come-nc commented Oct 11, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@vitormattos
Copy link
Contributor

Hi @come-nc I found this error in an instance with version25.
Was the pull request with the backport made?

@come-nc
Copy link
Contributor

come-nc commented Oct 25, 2022

Hi @come-nc I found this error in an instance with version25. Was the pull request with the backport made?

No, I’m gonna retrigger the bot and backport by hand if needed.

@come-nc
Copy link
Contributor

come-nc commented Oct 25, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 25, 2022
Merged
@come-nc
Copy link
Contributor

come-nc commented Oct 25, 2022

/backport to stable24

@come-nc
Copy link
Contributor

come-nc commented Oct 25, 2022

/backport to stable23

This was referenced Oct 25, 2022
Merged
Merged
@come-nc
Copy link
Contributor

come-nc commented Oct 25, 2022

Hi @come-nc I found this error in an instance with version25. Was the pull request with the backport made?

Merged in 25/24/23 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 26
7 participants
@kesselb @come-nc @vitormattos @PVince81 @artonge @blizzz @solracsf