-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ldap search for attributes with no substr matching rule #32499
Conversation
It’s not limited to entryUUID it’s any field without a substr matching rule. |
5f6fab5
to
666ec01
Compare
@come-nc Much better indeed! |
Do we know whether this might have performance impact? I would assume not, but then I know those products and I would not be surprised… |
@blizzz I have no idea but I think the partial search we do anyway might be way more costly than the additional exact search. |
Certainly. What I wonder is whether the products handle this now smartly, or whether this has an additional performace penalty. For sure we cannot go without the appended wildcard for ordinary searches. An alternative would be a list of known attributes for which we do not add the wildcard. But, if this approach works out fine it is preferable – looks duplicated, but less complex. |
I think techincally you could query the ldap server for schema information to know which fields have substr matching rules and which have not. But that seems overkill for current situation. |
/rebase |
…s without a substr matching rule Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
666ec01
to
f3cd559
Compare
Wildcards are not supported when used in search filters for the
entryUUID
attribute. I guess it's the same for some other attributes as well.IMO we can make an exact search filter in this case.
Is there a cleaner way to address that issue?