Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only log diagnostic events if a treshhold is set #32382

Merged
merged 1 commit into from
May 16, 2022
Merged

only log diagnostic events if a treshhold is set #32382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1791,7 +1791,7 @@

/**
* Enforce the user theme. This will disable the user theming settings
* This must be a valid ITheme ID.
* This must be a valid ITheme ID.
* E.g. light, dark, highcontrast, dark-highcontrast...
*/
'enforce_theme' => '',
Expand Down Expand Up @@ -2146,6 +2146,8 @@

/**
* Limit diagnostics event logging to events longer than the configured threshold in ms
*
* when set to 0 no diagnostics events will be logged
*/
'diagnostics.logging.threshold' => 0,

Expand Down
2 changes: 1 addition & 1 deletion lib/private/Diagnostics/EventLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private function writeLog(IEvent $event) {
$timeInMs = round($duration * 1000, 4);

$loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0);
if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) {
if ($loggingMinimum === 0 || $timeInMs < $loggingMinimum) {
return;
}

Expand Down