Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't unjail the path when getting the storage info #32335

Merged
merged 1 commit into from
May 12, 2022
Merged

don't unjail the path when getting the storage info #32335

merged 1 commit into from
May 12, 2022

Conversation

icewind1991
Copy link
Member

the original reason for adding it no longer exist.

This was added with #30985 since then the share source storage was also used, however this was changed with #32076

Fixes #32178

@icewind1991
don't unjail the path when getting the storage info
643ef06 
the original reason for adding it no longer exist.

This was added with #30985 since then the share source storage was also used, however this was changed with #32076

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 11, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone May 11, 2022
@icewind1991 icewind1991 requested review from a team, PVince81, ArtificialOwl and come-nc and removed request for a team May 11, 2022 09:42
@icewind1991 icewind1991 mentioned this pull request May 11, 2022
Closed
8 tasks
@solracsf solracsf mentioned this pull request May 11, 2022
Closed
@enoch85
Copy link
Member

enoch85 commented May 11, 2022

/backport to stable24

PVince81
PVince81 approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from artonge and CarlSchwan May 11, 2022 15:44
@artonge
Copy link
Contributor

artonge commented May 11, 2022

If I understand correctly, the error was caused because of an extra unjail operation. But I don't understand where the first one is

@PVince81 PVince81 mentioned this pull request May 12, 2022
Closed
8 tasks
@CarlSchwan CarlSchwan merged commit febbd21 into master May 12, 2022
@CarlSchwan CarlSchwan deleted the storage-info-dont-unjail branch May 12, 2022 18:59
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 12, 2022
Merged
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot May 12, 2022
@Ornanovitch
Copy link
Contributor

Thanks! Could you also backport to stable 23..?

@icewind1991
Copy link
Member Author

icewind1991 commented May 13, 2022 •
edited
Loading

no, 23 still needs this unjail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@come-nc come-nc Awaiting requested review from come-nc

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't open/view files, disk_free_space(): No such file or directory
7 participants
@icewind1991 @enoch85 @artonge @Ornanovitch @PVince81 @CarlSchwan @skjnldsv