-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SCSSCacher and compile scss files with npm-sass #32261
Conversation
To give a small performance overview in term of db requests loading dashboard page:
loading photo page:
loading files page:
This is with a hot redis cache. With a cold cache before the numbers were always above 100 and after this patch: the number is almost the same with and without hot cache. So really nice improvement :) |
|
cc @MorrisJobke as we talked about removing the scss cacher a while ago 😎 |
702d420
to
cbbf192
Compare
0960be6
to
ce39e3f
Compare
cool! so as I understand now there will be no more CSS or icon files in the appdata directory ? |
That is correct. |
ce39e3f
to
f4a6d3b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Addressed @PVince81 :) |
641e007
to
55534d5
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks fine now
next up: adjust all apps we know of
Tested again and works fine here :) |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
55534d5
to
264adf0
Compare
Rebased, ready to get in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally looked at the full diff and made sure it works in every corner case like it should
🎉🎉🎉🎉🎉 |
Nice @skjnldsv! Thanks for moving this one forward 🥳 |
Replace #31743