Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix social sharing buttons #32139

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix social sharing buttons #32139

merged 1 commit into from
Apr 27, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 25, 2022 •
edited
Loading

Fix #31970

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/31970/fix-social-sharing-buttons \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 25, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Apr 25, 2022
@szaimen szaimen force-pushed the fix/31970/fix-social-sharing-buttons branch from 61dcffd to 6600bc5 Compare April 25, 2022 15:48
@szaimen szaimen requested review from artonge, a team, PVince81 and skjnldsv and removed request for a team April 25, 2022 15:54
@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Apr 26, 2022

/rebase

@artonge
Copy link
Contributor

artonge commented Apr 26, 2022

Wasn't it fixed by #31596 ?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 26, 2022

Wasn't it fixed by #31596 ?

seems like not... I must admin I didn't test the mentioned PR and did not find it when looking for it hence I create this one...
Either way the !important has missed from the mentioned PR...

@szaimen
fix social sharing buttons
dfa14c7 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the fix/31970/fix-social-sharing-buttons branch from 6600bc5 to dfa14c7 Compare April 26, 2022 14:42
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 27, 2022
@CarlSchwan
Copy link
Member

ci failure unrelated

@CarlSchwan CarlSchwan merged commit 5570661 into master Apr 27, 2022
@CarlSchwan CarlSchwan deleted the fix/31970/fix-social-sharing-buttons branch April 27, 2022 11:24
This was referenced Apr 27, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@artonge artonge Awaiting requested review from artonge

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

[24.0.0b2] Social buttons icons
4 participants
@szaimen @artonge @CarlSchwan @skjnldsv