Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap contact search result in a link #31931

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Wrap contact search result in a link #31931

merged 1 commit into from
Apr 11, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 11, 2022 •
edited
Loading

Supersede #31824
Fix #24807

@artonge artonge self-assigned this Apr 11, 2022
@devsekar-1992 @artonge
Wrap contact search result in a link
7696e3f 
Signed-off-by: Gnana Sekar <developersekar1992@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the contact-popover-hyperlink-issue-2 branch from acef539 to 7696e3f Compare April 11, 2022 15:13
@artonge artonge added this to the Nextcloud 24 milestone Apr 11, 2022
szaimen
szaimen approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but didn't test

@szaimen szaimen requested review from a team, PVince81, skjnldsv and Pytal and removed request for a team April 11, 2022 15:27
@artonge
Copy link
Contributor Author

artonge commented Apr 11, 2022

@devsekar-1992 can you check that the change is still good ?

@devsekar-1992
Copy link
Contributor

@devsekar-1992 can you check that the change is still good ?

Yes @artonge

@Pytal Pytal merged commit 49d302d into master Apr 11, 2022
@Pytal Pytal deleted the contact-popover-hyperlink-issue-2 branch April 11, 2022 17:43
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2022
@artonge
Copy link
Contributor Author

artonge commented Apr 12, 2022

Thank you @devsekar-1992 ! Sorry it was such a drag for you, hopefully it will be smoother next time! :)

@devsekar-1992
Copy link
Contributor

@artonge No problem. It's one of the learnings of my first open-source contribution.

Thank you @szaimen @artonge @Pytal for accepting my first open-source contribution

@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
@Pytal Pytal mentioned this pull request Jun 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: contacts menu
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Contacts menu, more intuitive link to contact details
4 participants
@artonge @devsekar-1992 @Pytal @szaimen